ResponsiveImagesCG / wp-tevko-responsive-images

Fully responsive image plugin for wordpress
449 stars 53 forks source link

tevkori_get_sizes() improvements #205

Closed joemcgill closed 8 years ago

joemcgill commented 8 years ago

Following c3057fb, we should also avoid calling image_downsize() in tevkori_get_sizes(). This commit uses only the useful bits from the internals of the image_downsize() function to get the width of an image given and id and size.

I've also been considering whether the internals of tevkori_get_sizes() could be simplified to only output our smart default, rather than accepting an array of arguments for creating complex sizes patterns. Since the value is filterable, devs can already modify this value however they want.

jaspermdegroot commented 8 years ago

Looks good to me :+1: