search

ResponsiveImagesCG / wp-tevko-responsive-images

Fully responsive image plugin for wordpress
449 stars 53 forks source link

Filters hooked to `tevkori_image_sizes_args` are no longer firing in 3.0.0 #226

Closed joemcgill closed 8 years ago

joemcgill commented 8 years ago

See this issue on WP.org

jaspermdegroot commented 8 years ago

I don't think they are never firing, because we have a unit test for this which is passing. I will try to reproduce the issue.

joemcgill commented 8 years ago

The unit test assumes we're calling the tevkori_get_sizes() function, but that function no longer runs by default after an upgrade to 3.0.0. What we need to do is route any hooks attached to this function to the wp_calculate_image_sizes() function instead.

jaspermdegroot commented 8 years ago

I see. So the deprecated tevkori_image_sizes_args filter should still be applied when the new sizes function runs? I thought it only had to be applied when the deprecated tevkori_get_sizes() function is called. I can create a PR for this.

joemcgill commented 8 years ago

That's correct. If someone has a filter applied to the old tevkori_get_sizes hook, their function should still affect the sizes attribute after upgrading to 3.0