Closed jaspermdegroot closed 8 years ago
These are issues in the plugin as well as in WP core trunk.
wp_get_attachment_image_srcset():
wp_get_attachment_image_srcset()
$image_meta
wp_calculate_image_srcset():
wp_calculate_image_srcset()
$attachment_id
wp_calculate_image_srcset:
wp_calculate_image_srcset
wp_get_attachment_image_sizes():
wp_get_attachment_image_sizes()
wp_calculate_image_sizes():
wp_calculate_image_sizes()
$size
$image_src
= null
wp_calculate_image_sizes:
wp_calculate_image_sizes
string|null
array|null
Closed after manually merging #250
I've added the changes in 88e8480 to the original ticket in Trac (#34612) for adding the wp_calculate_image_sizes() function.
All other docs changes should be handled in a big docs sweep through Core.
These are issues in the plugin as well as in WP core trunk.
wp_get_attachment_image_srcset()
:$image_meta
missing "Default null"wp_calculate_image_srcset()
:$attachment_id
missing "Default 0"wp_calculate_image_srcset
:$attachment_id
: add to description " or 0".wp_get_attachment_image_sizes()
:$image_meta
missing "Default null"wp_calculate_image_sizes()
:$size
: remove " Default 'medium'." since it doesn't have a default$image_src
should be documented as second instead of fourth$image_src
missing "Default null" (= null
is missing in the code as well)$image_meta
missing "Default null" (= null
is missing in the code as well)$attachment_id
missing "Default 0"wp_calculate_image_sizes
:$size
: remove " Default 'medium'." from description$image_src
type should bestring|null
and add to description " or null".$image_meta
type should bearray|null
and add to description " or null".$attachment_id
: add to description " or 0".