search

ResponsiveImagesCG / wp-tevko-responsive-images

Fully responsive image plugin for wordpress
449 stars 53 forks source link

Apply Upstream Fixes #262

Closed joemcgill closed 8 years ago

joemcgill commented 8 years ago

This includes the upstream fixes from core that address #259, #260, and #261. It also adjusts a few of our internal test loading so that the filters applied to responsive images in Twenty Sixteen would not affect our expected results.

joemcgill commented 8 years ago

Commit 3e79568 brings in the changes from WP35820 and resolves #263.

jaspermdegroot commented 8 years ago

@joemcgill - Looks all good now. Only had a comment about tevkori_get_media_embedded_in_content().

joemcgill commented 8 years ago

By moving the function to the deprecated functions file it will also be available when on WP 4.4+.

I wasn't thinking about that. I really think we should discourage use (not that anyone will) so making it deprecated in this release and then removing in the next full release is a fine plan.

joemcgill commented 8 years ago

Added a12fa52 which fixes a bug introduced by 3e79568 that would fail to add srcset attributes to images when the scheme of the image src didn't match the scheme of wp_upload_dir().

See https://core.trac.wordpress.org/ticket/35045

joemcgill commented 8 years ago

I also reverted the commit that made tevkori_get_media_embedded_in_content() a wrapper function for get_media_embedded_in_content() for now, as we discussed.