search

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
242 stars 215 forks source link

RestComm sends EndSignal and PlayAnnouncement signal simultaneously #1622

Closed hrosa closed 7 years ago

hrosa commented 7 years ago

This can cause unpredictable behaviour on Media Server side. Instead, RC should send EndSignal and wait for response from RMS before sending the play.

As described on https://github.com/RestComm/Restcomm-Connect/issues/1621

abdulazizali77 commented 7 years ago

@gvagenas Are you currently working on this issue (or #1621, #1623)? If not i would like to have a go at it (rather, one of them)

gvagenas commented 7 years ago

Hi @abdulazizali77 none is working on those issues and it would be great if you want to take over and work on them. I will assign issues to you

abdulazizali77 commented 7 years ago

Thanks @gvagenas . I notice that the in-progress tag is hardly used, so its hard to tell whether an assigned issue is being worked on or not. Additionally some fixed issues dont seem to be set to closed.... :)

maria-farooq commented 7 years ago

Good point @abdulazizali77 about in progress label, i agree that we should use it to make things more clear. Thanks for raising the point. by the way is this in progress?

Thanks -Maria-

abdulazizali77 commented 7 years ago

Yes @maria-farooq, #1621 and #1622 both seem to stem from problems in VoiceInterpreter on conference instances. Im not too sure yet with #1623, but all of them revolve around conference so im sort of addressing the three in tandem. Do you have any advice?

abdulazizali77 commented 7 years ago

@maria-farooq @gvagenas @deruelle Seems my initial idea should still apply, i will potentially add substates to MgcpMediaGroup Active state, VoiceInterpreter Conferencing state and preverify and consume the commands in the RCML. I have not completely ascertained where, but potentially IvrEndpoint Call Bridge Conference the *Controllers, maybe GenericEndpoint will also need to be changed The Request-Response path from VoiceInterpreter all the way to MediaGateway is a long and messy one..

maria-farooq commented 7 years ago

Thanks Abdul.Aziz, Can you please share a sequence diagram as per your idea, Best regards Maria

maria-farooq commented 7 years ago

Hi @abdulazizali77 ,

Do we have any update on it, i see in progress label to this issue.

thanks Maria

maria-farooq commented 7 years ago

as per discussion lets implement https://github.com/RestComm/Restcomm-Connect/issues/2024 instead