RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
242 stars 215 forks source link

configDaoManager() still tries to update restcomm.xml #1776

Closed peteroyle closed 7 years ago

peteroyle commented 7 years ago

Hi,

After upgrading RestComm from 7.9 to 8.0, running against MySQL, I noticed this error when I tried logging in to the RestComm dashboard UI:

Error querying database.  Cause: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '"restcomm_accounts" WHERE "email_address"='administrator@company.com'' at line 1
The error may exist in file:///usr/share/restcomm/standalone/deployments/restcomm.war/WEB-INF/sql/accounts.xml
The error may involve org.mobicents.servlet.sip.restcomm.dao.AccountsDao.getAccountByEmail-Inline
The error occurred while setting parameters
SQL: SELECT * FROM "restcomm_accounts" WHERE "email_address"=?;
Cause: com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '"restcomm_accounts" WHERE "email_address"='administrator@company.com'' at line 1
    org.apache.ibatis.exceptions.ExceptionFactory.wrapException(ExceptionFactory.java:23)
    org.apache.ibatis.session.defaults.DefaultSqlSession.selectList(DefaultSqlSession.java:107)
    org.apache.ibatis.session.defaults.DefaultSqlSession.selectList(DefaultSqlSession.java:98)
    org.apache.ibatis.session.defaults.DefaultSqlSession.selectOne(DefaultSqlSession.java:62)
org.restcomm.connect.dao.mybatis.MybatisAccountsDao.getAccount(MybatisAccountsDao.java:113)
...

After some digging I realised that the element has been moved out of restcomm.xml and into dao-manager.xml (see #1625), but the configDaoManager() function of the autoconfig.d/config-mysql.sh script is still trying to search/replace it in restcomm.xml.

This should be a trivial fix, so I will do some testing and hopefully have the world's simplest pull request submitted shortly.

peteroyle commented 7 years ago

Oops, never mind this has already been taken care of in #1749