search

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
244 stars 215 forks source link

Issue #1981: MultiProvider RC and Extensions API implementation: redundant code in SmsService and SmmpMessageHandler #2123

Closed abdulazizali77 closed 7 years ago

abdulazizali77 commented 7 years ago

Code to process and handle extension hooks, ExtensionRequests and ExtensionResponse in SmsService and SmppMessageHandler are identical (executePreOutboundAction executePostOutboundAction handleExtensionResponse ). This could be centralized in the Extensions Controller implementation or the RC Bootstrapper implementation. This requires design discussion and iterative implementation of the Extensions API and implementation design. This is blocked by #2125 and #2126

abdulazizali77 commented 7 years ago

@gvagenas This is already fixed in the https://github.com/RestComm/Restcomm-Connect/pull/2007/commits/09b166d59132e7673946fc519ad917e9860b9e5b so closing this