search

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
240 stars 214 forks source link

allow proxy-authorization header to omit algortihm param #2952

Closed jaimecasero closed 6 years ago

jaimecasero commented 6 years ago

What this PR does / why we need it: allow proxy-authorization header to omit algortihm param. Allow clients not setting this param to work with Restcomm (linphone) Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #https://telestax.atlassian.net/browse/BS-112

Special notes for your reviewer:

gvagenas commented 6 years ago

@jaimecasero Patch looks good. I see we have a new dependency powermock but we already have mockito in the project, isn't mockito enough to cover what we need to test at CallControlHelperTest. If not, should we plan to move to powermock and remove mockito so we dont clutter the project with unused depdencies?

jaimecasero commented 6 years ago

@gvagenas i started the test trying to mock static parts (restcommconfiguration singleton) of the scenario. But finally its not necessary. I will remove any powermock dependency,as its not really required by now.

Since the project contains lots of static singletons access, it maybe required later. Mockito and Powermock are complementary,so i dont see an issue on potentially use both.

In any case, let me remove this,since its not required at the moment

gvagenas commented 6 years ago

@jaimecasero ok great. Regarding the Powermock, I haven't worked with it and didn't know it compliments mockito, and that's why my comment.