search

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
240 stars 214 forks source link

[WIP] Jira#2087 fix Say/Play cannot be played after Dial verb #2957

Closed xhoaluu closed 6 years ago

xhoaluu commented 6 years ago

What this PR does / why we need it: Say/Play Verb after Dial Verb, If callee is busy (486 BUSY) or in another call (480 Unavailable), RC will stop Say/Play verb really fast.

RC stop ringing tone then asking for next verb without waiting for mgcp NTFY. If next verb is say/play that makes RC moves to playing state before mgcp NTFY for stoping ringtone actually come to RC. When mgcp NTFY for stoping ringtone come, RC is in playing stay will stop say/play verb

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # https://telestax.atlassian.net/browse/RESTCOMM-2087 Special notes for your reviewer: There is 2 big customer is waiting for this fix.

xhoaluu commented 6 years ago

Jenkin result is same as baseline.

xhoaluu commented 6 years ago

close this PR as there is better solution: https://github.com/RestComm/Restcomm-Connect/pull/2960

jaimecasero commented 6 years ago

@xhoaluu can you merge with latest master so test results are updated on jenkins. I think some tests failing on this branch were solved in master recently