search

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
240 stars 214 forks source link

jira_2087 Say/Play verb can be executed in failed Dial verb. #2960

Closed xhoaluu closed 6 years ago

xhoaluu commented 6 years ago

What this PR does / why we need it: Say/Play Verb after Dial Verb, If callee is busy (486 BUSY) or in another call (480 Unavailable), RC will stop Say/Play verb really fast.

RC stop ringing tone then asking for next verb without waiting for mgcp NTFY. If next verb is say/play that makes RC moves to playing state before mgcp NTFY for stoping ringtone actually come to RC. When mgcp NTFY for stoping ringtone come, RC is in playing stay will stop say/play verb

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # https://telestax.atlassian.net/browse/RESTCOMM-2087 Special notes for your reviewer: There is 2 big customer is waiting for this fix.

xhoaluu commented 6 years ago

All Failing testcases are passed in local environment.

jaimecasero commented 6 years ago

@xhoaluu i can see several test cases failing in jenkins https://cxs.restcomm.com/view/BackendSquad/view/ConnectCommunity/job/Restcom-CI-Multibranch/view/change-requests/job/PR-2960/lastCompletedBuild/testReport/

Im specially concerned about DialRecordingTest. Could you check those tests failure and confirm if PR is breaking those tests?

xhoaluu commented 6 years ago

@jaimecasero I just rebase this branch with master branch, result is here: https://cxs.restcomm.com/job/Restcom-CI-Multibranch/job/PR-2960/4/

I ran 2 failing testcase on local and the result were passed.