bs-253: MGCP sik for DTMF on RMS case.

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform

http://www.restcomm.com/

GNU Affero General Public License v3.0

240 stars 214 forks source link

bs-253: MGCP sik for DTMF on RMS case. #2971

Closed xhoaluu closed 6 years ago

xhoaluu commented 6 years ago

What this PR does / why we need it: For now, DTMF will not accept "" at the begining of collected result. RC should include sik parten "123456789" in PlayColect MGCP.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # https://telestax.atlassian.net/browse/BS-253 Special notes for your reviewer:

xhoaluu commented 6 years ago

As All testsuite in RestComm is Media server mock, We cannot add testcase to test this feature. manually test result pcap attached here. bs-253.pcapng.zip

jaimecasero commented 6 years ago

i can see new sik parameter, and RMS accepting the command Media Gateway Control Protocol RQNT (NotificationRequest) Transaction ID: 147483704 Endpoint: mobicents/ivr/7@192.168.1.3:2427 Version: MGCP 1.0 [The response to this request is in frame 12] Parameters NotifiedEntity (N): restcomm@192.168.1.3:2727 RequestIdentifier (X): 10 SignalRequests (S): AU/pc(cb=true mx=6 fdt=50 idt=50 sik=*0123456789 eik=#) RequestedEvents (R): AU/oc(N),AU/of(N)

jaimecasero commented 6 years ago

considering test results on CXS, and manual testing performed, i think we are ok on merging this