RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
240 stars 214 forks source link

Shell scripts does not support self-closing XML at SMTP #2999

Closed ghjansen closed 4 years ago

ghjansen commented 4 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

bug

What happened:

Shell configuration script does not support self-closing XML elements at SMTP configuration.

e.g. The following XML segment will be ignored by config-utelsil.sh, as the sed regular expression matches only with <element>.*</element>:

  <smtp-service>
    <host/>
    <user/>
    <password/>
    <port/>
  </smtp-service>

What you expected to happen:

SMTP configuration performed normally, leaving all XML elements with the values informed at advanced.conf

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

It seems that self-closing XML elements are being delivered by default in restcomm.xml with the releases. Not sure if relevant, but maybe all scripts with sed command should support this format.

Environment:

ghjansen commented 4 years ago

Fixed via #3000