search

RestComm / Restcomm-Connect

The Open Source Cloud Communications Platform
http://www.restcomm.com/
GNU Affero General Public License v3.0
241 stars 215 forks source link

RestComm need to properly handle Record failure. #999

Open leftyb opened 8 years ago

leftyb commented 8 years ago

RestComm always assumes MS replies with rc parameter (return code) but in this case, MS does not. RestComm should be prepared to handle this situation.

https://github.com/RestComm/Restcomm-Connect/blob/master/restcomm/restcomm.mgcp/src/main/java/org/mobicents/servlet/restcomm/mgcp/IvrEndpoint.java#L167

hrosa commented 8 years ago
screen shot 2016-04-14 at 17 53 32
hrosa commented 8 years ago

https://tools.ietf.org/html/rfc2897#section-6

hrosa commented 8 years ago

16:41:32,313 ERROR org.mobicents.servlet.restcomm.mgcp.IvrEndpoint null: java.lang.NumberFormatException: null at java.lang.Integer.parseInt(Integer.java:454) [rt.jar:1.7.0_80] at java.lang.Integer.parseInt(Integer.java:527) [rt.jar:1.7.0_80] at org.mobicents.servlet.restcomm.mgcp.IvrEndpoint.notification(IvrEndpoint.java:167) [restcomm.mgcp-7.6.0.863.jar:] at org.mobicents.servlet.restcomm.mgcp.IvrEndpoint.onReceive(IvrEndpoint.java:125) [restcomm.mgcp-7.6.0.863.jar:] at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:159) [akka-actor_2.10-2.1.2.jar:] at akka.actor.ActorCell.receiveMessage(ActorCell.scala:425) [akka-actor_2.10-2.1.2.jar:] at akka.actor.ActorCell.invoke(ActorCell.scala:386) [akka-actor_2.10-2.1.2.jar:] at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:230) [akka-actor_2.10-2.1.2.jar:] at akka.dispatch.Mailbox.run(Mailbox.scala:212) [akka-actor_2.10-2.1.2.jar:] at akka.dispatch.ForkJoinExecutorConfigurator$MailboxExecutionTask.exec(AbstractDispatcher.scala:506) [akka-actor_2.10-2.1.2.jar:] at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:262) [scala-library-2.10.1.jar:] at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:975) [scala-library-2.10.1.jar:] at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1478) [scala-library-2.10.1.jar:] at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:104) [scala-library-2.10.1.jar:]

hrosa commented 8 years ago

record.pcap.zip

hrosa commented 8 years ago

Issue must be fixed on Media Server side, not RestComm. Related issue https://github.com/RestComm/mediaserver/issues/115