search

RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

Enhanced Statistics #10

Closed ovoo-unif closed 7 years ago

ovoo-unif commented 7 years ago

Hi,

can you consider the below changes. We would like to have the following new features related in statistics:

  1. For request processing stats: min, max, avg for processing and response times.
  2. A possibility to Get&Reset at once.
  3. There is no need to have those new figures described with some names. It's much more better for integration with monitoring tools, to dump the values as CSV like format.

Regards, adam

vetss commented 7 years ago

Hello @ovoo-unif

The PR contains changing of pom.xml and formatting of code Is it possible to provide the update that contains only siginificant changing of the problem ?

We need to add an update into another branch too ("netty4") I will try to apply your commit (if no conflicts) if you provide a short (only significant changing) version We need to aupdate also another branch because of the most probably we will try to switch to it further

ovoo-unif commented 7 years ago

Ok Sergey,

then I will do the changes + separate changes for netty4.

Let you know when done.

Regards, adam

ovoo-unif commented 7 years ago

Hi Sergey,

I've just done the changes.

Same changes are on branch netty4@pr-10 - do you want me to create a separate PR for this branch (netty4)?

Regards, adam