search

RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

Adding of extra statistics counters #14

Closed vetss closed 7 years ago

vetss commented 7 years ago

Hello @ovoo-unif,

thanks for providing of of PR for adding some statistics: https://github.com/RestComm/cloudhopper-smpp/pull/12 https://github.com/RestComm/cloudhopper-smpp/pull/13

Please provide info here in the issue which counters you are introducing of the PRs and then we will be able to add code into a repo.

ovoo-unif commented 7 years ago

Hi,

the counters correspond to the existing ones (ESME stats):

    public String getRxDataSMCounter();
    public String getRxDeliverSMCounter();
    public String getRxEnquireLinkCounter();
    public String getRxSubmitSMCounter();
    public String getTxDataSMCounter();
    public String getTxDeliverSMCounter();
    public String getTxEnquireLinkCounter();
    public String getTxSubmitSMCounter();

With the following enhancements:

  1. The counter value is reset atomically at the get (not possible in the current implementation).
  2. The time stats (Wait, Processing, Response) are extended with min and max (not only avg).
  3. The counter values are returned in the CSV form (easy for machine parsing and further processing). The current format is a bit odd, Perhaps good for human, but not for further operation and maintenance (monitoring and notification).

With kind regards, adam

vetss commented 7 years ago

Hello @ovoo-unif

I have added your PRs. Thanks for your update.