search

RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

Allow skipping field validation in DeliveryReceipt parseShortMessage #16

Closed JChrist closed 7 years ago

JChrist commented 7 years ago

As mentioned in issue #15 the static method parseShortMessage in DeliveryReceipt did not allow skipping field validation, throwing an exception if a field did not match the validation requirements. This might not always be desired, e.g. in the case of validating that the err field is at most 3 characters.

JChrist commented 7 years ago

I haven't added any new tests, since I have trouble compiling the project, executing mvn clean package results in compilation errors.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project ch-smpp: Compilation failure: Compilation failure:
[ERROR] /local/jchrist/projects/cloudhopper-smpp/src/main/java/com/cloudhopper/smpp/impl/DefaultSmppServer.java:[238,24] error: incompatible types: String cannot be converted to Marker
[ERROR] /local/jchrist/projects/cloudhopper-smpp/src/main/java/com/cloudhopper/smpp/impl/DefaultSmppServer.java:[281,20] error: incompatible types: String cannot be converted to Marker

Can you please advise what I might be doing wrong? My plan is that once I fix the compilation issue, I will add tests and then backport the change to master

deruelle commented 7 years ago

@JChrist can you please sign the Contributor License Agreement at https://telestax.com/open-source/#Contribute so we can accept your contributions ?

JChrist commented 7 years ago

Hi @deruelle ! Thanks for your quick response! I just submitted the agreement. The CI failure is similar to the one I am referring to.

deruelle commented 7 years ago

Thanks @JChrist. @vetss can you please review this PR ?