RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

Allow skipping field validation in DeliveryReceipt parseShortMessage #17

Closed JChrist closed 7 years ago

JChrist commented 7 years ago

As mentioned in issue #15 the static method parseShortMessage in DeliveryReceipt did not allow skipping field validation, throwing an exception if a field did not match the validation requirements. This might not always be desired, e.g. in the case of validating that the err field is at most 3 characters.

I closed PR https://github.com/RestComm/cloudhopper-smpp/pull/16 and opened a new one, since I understood that my previous attempt had messed remote branches and the PR was not based on the restcomm/netty4 branch. I believe I did it correctly this time, also adding tests for backwards-compatibility and the added functionality