RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

Threads get stuck at DefaultSmppSession.sendRequestPd:530 #20

Closed olenara closed 6 years ago

olenara commented 6 years ago

We have noticed that when the network between client and server or threads get stuck on line 530 in DefaultSmppSession. The code is:

// write the pdu out & wait timeout amount of time ChannelFuture channelFuture = this.channel.write(buffer).await(); I think that the fix should be something like this:

// write the pdu out & wait timeout amount of time ChannelFuture channelFuture = this.channel.write(buffer).await(timeoutMillis); This is on version 5.0.7 and 5.0.8

olenara commented 6 years ago

Closed by https://github.com/RestComm/cloudhopper-smpp/commit/6be5875f120fcc7855147dfbb69a9b21672a66af