RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

Feature/client local bind #22

Closed JChrist closed 5 years ago

JChrist commented 7 years ago

This PR contains several changes:

gsaslis commented 6 years ago

@JChrist would you please consider splitting this PR into two (or more) for each of the different changes you've made here?

while this may be a desirable feature (especially if it doesn't break backwards-compatibility, which, btw, is hard to tell from a quick look at this PR) and we might want to merge that in, the extra changes you're introducing are really pushing back the chances of this getting properly reviewed some time soon.

In any case, thanks for your time and effort! It is greatly appreciated!

gsaslis commented 6 years ago

@JChrist any chance you have some time to come round to this ?