Closed koeff closed 6 years ago
@koeff thanks for contributing!!
is this still WIP ? (asking because travis tests are failing, and that will be blocking us reviewing this pr)
It isn't WIP, unstable test com.cloudhopper.smpp.tlv.TlvTest
failed (https://travis-ci.org/RestComm/cloudhopper-smpp/builds there are the same failed builds).
Ok, thanks @koeff and apologies for the terribly late reply here.
Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with reviewing this?
Thanks in advance! Yorgos
Have signed CLA
thanks @koeff !
Passing this on for review to our @RestComm/messaging-squad ;)
Thanks @koeff for your contribution 👍 and sorry again for the delayed review. Your PR is now merged 🥇
…resources such as WindowMonitor for proper session close and clean up.
Issue: https://github.com/RestComm/cloudhopper-smpp/issues/9
@see also https://github.com/twitter/cloudhopper-smpp/issues/45 https://github.com/twitter/cloudhopper-smpp/commit/ba14f94e7d2f84cad198e6bafaa6a15ac6fdfce4