search

RestComm / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
14 stars 22 forks source link

+ Added session destroy on bind error. Calling destroy will clean up … #24

Closed koeff closed 6 years ago

koeff commented 6 years ago

…resources such as WindowMonitor for proper session close and clean up.

Issue: https://github.com/RestComm/cloudhopper-smpp/issues/9

@see also https://github.com/twitter/cloudhopper-smpp/issues/45 https://github.com/twitter/cloudhopper-smpp/commit/ba14f94e7d2f84cad198e6bafaa6a15ac6fdfce4

gsaslis commented 6 years ago

@koeff thanks for contributing!!

is this still WIP ? (asking because travis tests are failing, and that will be blocking us reviewing this pr)

koeff commented 6 years ago

It isn't WIP, unstable test com.cloudhopper.smpp.tlv.TlvTest failed (https://travis-ci.org/RestComm/cloudhopper-smpp/builds there are the same failed builds).

gsaslis commented 6 years ago

Ok, thanks @koeff and apologies for the terribly late reply here.

Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with reviewing this?

Thanks in advance! Yorgos

koeff commented 6 years ago

Have signed CLA

gsaslis commented 6 years ago

thanks @koeff !

Passing this on for review to our @RestComm/messaging-squad ;)

FerUy commented 6 years ago

Thanks @koeff for your contribution 👍 and sorry again for the delayed review. Your PR is now merged 🥇