RestComm / gmlc

Restcomm Location Server
http://www.restcomm.com/
GNU Affero General Public License v3.0
17 stars 40 forks source link

Processing of MAP errors / rejects #15

Closed vetss closed 8 years ago

vetss commented 8 years ago

We need to add of processing of MAP errors / rejects and return proper info for this into HTTP responses.

deruelle commented 8 years ago

We are evaluating which option is best:

  1. reply with a custom HTTP Response code
  2. Do it like for CAMEL GW
  3. Do it like USSD GW
dsendind commented 8 years ago

If I see it from a product experience perspective, I think that providing a map from typical MAP to HTTP such as "Absent Subscriber", "Unknown" or other type could enrich the experience. I am sure that this will be demanded somehow sooner or later..

nhanth87 commented 8 years ago

Some comment from me: Most of error code will return in onErrorComponent() public void onErrorComponent(ErrorComponent event, ActivityContextInterface aci) { MAPErrorMessage mapErrorMessage = event.getMAPErrorMessage(); long error_code = mapErrorMessage.getErrorCode().longValue();

continueHttpError(error_code, true);

}

vetss commented 8 years ago

Tran, as for your last comment:

vetss commented 8 years ago

Fixed by:

https://github.com/RestComm/gmlc/commit/e14a3c04765650055b8d7efdb30680d8d28aea2c

vetss commented 8 years ago

Extra fix:

https://github.com/RestComm/gmlc/commit/93798c18e64531ae75f45573e250bf2c11d522cd