search

RestComm / gmlc

Restcomm Location Server
http://www.restcomm.com/
GNU Affero General Public License v3.0
17 stars 40 forks source link

Remove the jibx maven plugin #48

Closed angrygreenfrogs closed 8 years ago

angrygreenfrogs commented 8 years ago

The full back-story is here: https://github.com/RestComm/gmlc/issues/44

The end result was that I put a work-around in place that uses the maven jibx plugin for the "generate-code" step, but then directly calls a local copy of jibx for the binding process and avoids the plugin due to a weird bug.

Considering the plugin is getting out of date and seems to be unmaintained, I'm leaning towards saying we just remove it and replace the generate-code step as well with a direct call to JiBX. This is mostly a reminder so I'll figure that out later and do it.

angrygreenfrogs commented 8 years ago

At present the JiBX jar files are directly included in the GMLC code-base. If we remove the plugin and go with directly using jibx, perhaps we can still find a way to have it be a downloaded dependency rather than including the jars as I have at the moment.

angrygreenfrogs commented 8 years ago

@FerUy I'm going to take this one over and just get it resolved shortly.

angrygreenfrogs commented 8 years ago

The decision is to remove the maven plugin as per comments above.

FerUy commented 8 years ago

Agreed in the decision taken, was about to propose that too. Thanks @angrygreenfrogs