Moved request specific class fields to CMP fields or local variables to solve race conditions

Vanit commented 8 years ago

class fields requestingMsisdn and httpRequestType were merged into an internal class HttpRequest, which is saved as a CMP field
class fields for the CGI response were merged into an internal class CGIResponse, which is now explicitly passed to the http response method for output

Resolves #66

FerUy commented 8 years ago

Nicely done @Monix, thanks!

Vanit commented 8 years ago

No problem! :)

FerUy commented 8 years ago

@Monix we have a problem with this PR.

GET requests works fine (e.g. http://127.0.0.1:8080/restcomm/gmlc/rest?msisdn=577438634) but when trying MLP request intended for success (not dummy number), we are getting this error:

$ curl -X POST -d @mlpreq.txt http://192.168.26.128:8380/restcomm/gmlc/mlp `<?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE svc_result SYSTEM "MLP_SVC_RESULT_310.DTD">

SYSTEM FAILURE IO failure generating XML ` Please notice yesterday I worked on issue #8 and merged the PR #68 , so you need to sync with master branch before fixing this. As you worked on this I believe you'll solve it faster, albeit I'll investigate too what could have happened.

RestComm / gmlc

Moved request specific class fields to CMP fields or local variables to solve race conditions #67