RestComm / jain-sip

Disclaimer: This repository is a git-svn mirror of the project found at http://java.net/projects/jsip whose original repository is developed collaboratively by the Advanced Networking Technologies Division at the National Institute of Standards and Technology (NIST) - an agency of the United States Department of Commerce and by a community of individual and enterprise contributors. TeleStax, Inc. will perform some productization work, new features experimentation branches, etc for its TelScale jSIP product that doesn't concern the community from the main repository hence this git repository.

http://www.restcomm.com/

141 stars 151 forks source link

Feature/issue #101 update log4j library #132

Closed valliman closed 7 years ago

valliman commented 7 years ago

101 Upgrade to Log4j2.

I deleted most of the manual logger configuration in tests. I would suggest to provide a log4j2-test.xml or similar for such purposes. Is there an easy way to verify that everything works via the CI server before performing the changes? (Sadly my local setup is currently somehow broken and my machine refuses to open any ports... )

deruelle commented 7 years ago

Thanks @valliman ! @jaimecasero can you review ?

@valliman can you sign the Contributor License Agreement at http://www.telestax.com/open-source/#Contribute so we can accept your contribution ?

valliman commented 7 years ago

@deruelle I've signed the CLA today.

valliman commented 7 years ago

Hi, I re-worked the log4j2 upgrade, to use the log4j 1.2 API and I've reverted the silly logger renaming change.

jaimecasero commented 7 years ago

@valliman can you just start form a fresh PR with minimum commits/changes as discussed? I still can see lots of files changed (146) some of them just becuase of indentation fix. We cant merge this as it is now...