search

RestComm / jain-sip

Disclaimer: This repository is a git-svn mirror of the project found at http://java.net/projects/jsip whose original repository is developed collaboratively by the Advanced Networking Technologies Division at the National Institute of Standards and Technology (NIST) - an agency of the United States Department of Commerce and by a community of individual and enterprise contributors. TeleStax, Inc. will perform some productization work, new features experimentation branches, etc for its TelScale jSIP product that doesn't concern the community from the main repository hence this git repository.
http://www.restcomm.com/
141 stars 151 forks source link

Incoming SIP provisional responses with SDP marked as retransmitted #151

Closed gfigiel closed 6 years ago

gfigiel commented 7 years ago

There is an issue in Jain SIP RI that causes SIP11 RA does not deliver events to JSLEE application when provisional response (100 -200) is repeated with new content or header. The response is marked as retransmitted what prevents SIP11 RA from delivering the event towards SBB.

The issue is caused by comparing only response code (toString output) when checking response retransmission: https://github.com/RestComm/jain-sip/blob/b79cba1b809993f029bf6ff4a8083da50beb5c9a/src/gov/nist/javax/sip/stack/SIPClientTransactionImpl.java#L1548

A piece of the log message for the second 183 - with SDP

2017-06-09 21:13:23,353 INFO  [sip-UDPMessageChannelThread-5] [javax.slee.RAEntityNotification[entity=sip].SipResourceAdaptor] Dropping in dialog retransmission. Response:
SIP/2.0 183 Session Progress
Call-ID: 8655ee5d118fb53a61ec4315526c8f5d@10.96.48.40
CSeq: 1 INVITE
Allow: INVITE,ACK,OPTIONS,BYE,CANCEL,PRACK,UPDATE
Content-Type: application/sdp
Contact: <sip:10.203.8.188:5060;transport=UDP>
Content-Length: 265
gfigiel commented 7 years ago

Please assign me to this issue. I will make a PR in a while.