fix for an issue described #164, NIO TCP connection bug

RestComm / jain-sip

Disclaimer: This repository is a git-svn mirror of the project found at http://java.net/projects/jsip whose original repository is developed collaboratively by the Advanced Networking Technologies Division at the National Institute of Standards and Technology (NIST) - an agency of the United States Department of Commerce and by a community of individual and enterprise contributors. TeleStax, Inc. will perform some productization work, new features experimentation branches, etc for its TelScale jSIP product that doesn't concern the community from the main repository hence this git repository.

http://www.restcomm.com/

144 stars 152 forks source link

fix for an issue described #164, NIO TCP connection bug #176

Open pimenas opened 6 years ago

pimenas commented 6 years ago

This fixes issue described in the second comment in #164, and allows outgoing TCP connections once again (they were broken in commit 365fb3eb4948b3ef524738105d13399bc28ef819)

gsaslis commented 6 years ago

@pimenas Thanks for the PR ❤️ - appreciate you taking the time to contribute this!!

Could you please make sure you've signed our CLA as well?

Thanks in advance! Yorgos

pimenas commented 6 years ago

@gsaslis I remember signing the CLA a few months ago, when I made some other minor contributions.

gsaslis commented 6 years ago

sorry for the confusion @pimenas !

Passing this on for review.