RestComm / jain-sip

Disclaimer: This repository is a git-svn mirror of the project found at http://java.net/projects/jsip whose original repository is developed collaboratively by the Advanced Networking Technologies Division at the National Institute of Standards and Technology (NIST) - an agency of the United States Department of Commerce and by a community of individual and enterprise contributors. TeleStax, Inc. will perform some productization work, new features experimentation branches, etc for its TelScale jSIP product that doesn't concern the community from the main repository hence this git repository.
http://www.restcomm.com/
141 stars 151 forks source link

fix NameValueList equals, in case this is an empty NameValueList #177

Open macvoo opened 6 years ago

macvoo commented 6 years ago

Calling NameListValue#equals on a empty NameValueList (handing over another NameValueList) would always return true in the current implementation.

CodeSample: //Given: NameValueList a = new NameValueList(); NameValueList b = new NameValueList(); b.set("someName", "someValue"); //When a.equals(b); --> would be true, but should be false...

gsaslis commented 6 years ago

Hey @macvoo !

Thanks for taking the time to submit this PR ❤️ !!

Could you please take a look at our Open Source Playbook and then proceed with signing our CLA, so we can then move forward with processing this?

Thanks in advance! Yorgos

gsaslis commented 6 years ago

thanks for signing the CLA @macvoo !

Passing this on for review.