RestComm / jain-sip

Disclaimer: This repository is a git-svn mirror of the project found at http://java.net/projects/jsip whose original repository is developed collaboratively by the Advanced Networking Technologies Division at the National Institute of Standards and Technology (NIST) - an agency of the United States Department of Commerce and by a community of individual and enterprise contributors. TeleStax, Inc. will perform some productization work, new features experimentation branches, etc for its TelScale jSIP product that doesn't concern the community from the main repository hence this git repository.
http://www.restcomm.com/
144 stars 152 forks source link

Sending Reliable Provisional Responses does not update the DialogTable #192

Closed macvoo closed 5 years ago

macvoo commented 5 years ago

Hi, I noticed that {@link SIPServerTransactionImpl#sendResponse(Response)} takes care of updating the {@link SIPTransactionStack#dialogTable} but that {@link SIPServerTransactionImpl#sendReliableProvisionalResponse(Response)} does not do that.

As a result if the UAS sends reliable provisional responses, and receives PRACK requests for that, he does not recognize the dialog (the {@link DialogFilter#processRequest(SIPRequest, MessageChannel)} initiates a 481 CALL_OR_TRANSACTION_DOES_NOT_EXIST response.


EDIT: found {@link Dialog#sendReliableProvisionalResponse} which takes care of updating the {@link SIPTransactionStack#dialogTable}.