RestComm / jain-slee.ss7

Repository containing the jSS7 Resource Adaptors for JAIN SLEE
http://www.restcomm.com/
GNU Affero General Public License v3.0
6 stars 28 forks source link

CAP: sccp relay implementation #15

Open MarekPisarski opened 7 years ago

MarekPisarski commented 7 years ago

RA level implementation feature - related to https://github.com/RestComm/jss7/issues/192 Fulfiles the requirement to relay CAP IDP message to external IN node with possibility to change CAP IDP service key value

vetss commented 7 years ago

Hello @MarekPisarski

may be it is better to implement this feature fully in CAP stack and leave for CAP RA only wrappers ?

MarekPisarski commented 7 years ago

Thank you for you suggestions. It has been just created new branch https://github.com/ProIDS/jain-slee.ss7/tree/issue%2315-sccp-relay containing already implemented and funcionally tested SCCP relay on CAP level. It has been implemented that way to allow easy control on SBB level - when IDP is relayed and how service key modification is replaced. We selected this approach to implement customer's requirement in the most convinient way. It seems to be less complicated than implementation on stack level.

MarekPisarski commented 7 years ago

linked stack issue https://github.com/RestComm/jss7/issues/192

vetss commented 7 years ago

Hello @MarekPisarski

why usage of "stack approach" contradcits "We selected this approach to implement customer's requirement in the most convinient way"? I still recommend to implement it in stack level...

Can you please also answer my comment in https://github.com/RestComm/jss7/issues/192 ?