RestComm / jain-slee

The World's #1 Open Source JAIN-SLEE (JSLEE) 1.1 Implementation
http://www.restcomm.com/
GNU Affero General Public License v3.0
25 stars 50 forks source link

Typo in resources/http-servlet/war/src/main/webapp/WEB-INF/web.xml #109

Closed richardgood closed 7 years ago

richardgood commented 7 years ago

Restcomm.jar fails to deploy on Wildfly with current master configuration.

In resources/http-servlet/war/src/main/webapp/WEB-INF/web.xml the listener-class and servlet-class need to define the full classpath and not just the class name:

diff --git a/resources/http-servlet/war/src/main/webapp/WEB-INF/web.xml b/resources/http-servlet/war/src/main/webapp/WEB-INF/web.xml
index d80a73a..dd30211 100644
--- a/resources/http-servlet/war/src/main/webapp/WEB-INF/web.xml
+++ b/resources/http-servlet/war/src/main/webapp/WEB-INF/web.xml

@@ -9,13 +9,13 @@
        </welcome-file-list>
        <listener>
                <listener-class>
-                       HttpServletRaSessionListener
+                       org.restcomm.slee.resource.http.HttpServletRaSessionListener^M
                </listener-class>
        </listener>            
        <servlet>
                <servlet-name>${servlet-name}</servlet-name>
                <servlet-class>
-                       HttpServletRaServlet
+                       org.restcomm.slee.resource.http.HttpServletRaServlet^M
                </servlet-class>
         <init-param>
             <param-name>ra-entry-point-jndi-name</param-name>

With this change restcomm.jar deploys fine.

deruelle commented 7 years ago

@SergeyLee can you fix this ?

SergeyLee commented 7 years ago

@deruelle I fixed it already: https://github.com/RestComm/jain-slee.http/commit/b27694e85d94ce38fccf876c7bf337b34b980e36 so we can close this issue here.