search

RestComm / jain-slee

The World's #1 Open Source JAIN-SLEE (JSLEE) 1.1 Implementation
http://www.restcomm.com/
GNU Affero General Public License v3.0
25 stars 50 forks source link

Graceful shutdown feature implementation #90

Closed gfigiel closed 6 years ago

gfigiel commented 7 years ago

Solution for Issue #75 Graceful shutdown feature implementation

Based on branch 2.x

deruelle commented 7 years ago

Thanks @gfigiel ! @SergeyLee can you review ?

gfigiel commented 7 years ago

Hi, Please see the implementaiton for CAP RA as an example for using new interface: https://github.com/ProIDS/jain-slee.ss7/tree/issue%2314-graceful-shutdown

SergeyLee commented 7 years ago

Hi @gfigiel Who did testing JSLEE Release with Graceful shutdown on your side?

gfigiel commented 7 years ago

Hi Sergey - the slee in our TB is now ready to be tested but we have technical issues in test environment that blocked tests already. I assume the testing will be finished till end of this week by me and Dominik (@dblacha).

Br, Greg

SergeyLee commented 7 years ago

Hi @gfigiel I have reviewed your commits and have only one question: can you create also non regression tests for this feature?

gfigiel commented 7 years ago

Hi @SergeyLee We have still not finished new release tests as jDiameter extension problems are now "on air". Reagrding your question - please clarify what kind of tests do you mean? We reviewed the jain-slee but we have not found unit tests there.

SergeyLee commented 7 years ago

Hi @gfigiel JAIN SLEE has not unit tests for all modules and all purposes, you are right. But for some of them we have them. Like for components, congestion, jmx-property-editors, transactions, etc. For Graceful shutdown feature these tests is needed in the resource module, because main changes was created there.

satanatoly commented 6 years ago

implemented other version of graceful shutdown in commercial version, closing