RestComm / jdiameter

RestComm Diameter Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
112 stars 152 forks source link

Implement Diameter Request Timeout event #41

Open brainslog opened 8 years ago

brainslog commented 8 years ago

Currently timeouts are not passed to the application, leaving to the SLEE application to use other ways to detect those (eg, setting timers). A SLEE event type should be implemented in order to deliver the actual stack timeout.

Possibly Diameter application specific timer events should also be implemented (eg, Tx and Tcc in DCCA), but, if so, should be out of scope of this issue.

abdulazizali77 commented 7 years ago

Hi i assume this would be the Peer timeouts detailed in 6733 section 5.6 ? Im assuming we want to implement additional Timeout state transitions for R-Open and I-Open correct? since these transitions arent actually there in the table. Also in regards to CER, DWR, DPR timeouts in PeerImpl, im assuming timeouts are not yet implemented (as mentioned)? i havent looked thoroughly enough or tested/debugged it yet.

If it isnt already obvious, im interested to pick this task up, brief intro, i worked on diameter and ss7 in NSN few years back and i realize now my java and networking skills/knowledge need brushing up..... I have managed to build the jdiameter stack and injected messages with Seagull, and briefly looked at the code, havent managed to run dtrace on it yet to understand the complete function call flow

Apologies if all my assumptions are completely off track!

Incidentally, i see that none of the Milestones have a concrete date....

deruelle commented 7 years ago

@xphudin isn't this something you worked on already and were planning to push a Pull request for ?

@brainslog can you help answer @abdulazizali77 questions ?

phuongdinh1411 commented 7 years ago

yes, I did a PR.

abdulazizali77 commented 7 years ago

@phuongdinh1411 could you point me to the PR? Additionally is this issue still valid/open?

phuongdinh1411 commented 7 years ago

hi @abdulazizali77, you can see my PR here: https://github.com/RestComm/jain-slee.diameter/pull/19

abdulazizali77 commented 7 years ago

OK. didnt review the PR, but i assume it implements this issue.