search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
181 stars 218 forks source link

Resolves #4 #102

Closed vgsub closed 8 years ago

vgsub commented 8 years ago

Hi all,

I've implemented ATSI Req/Res with all related types and tested it with my own little test program. Unfortunately I don't have real traces so I'm unable to create unit test for this operation. If you provide traces I implement tests. Also I didn't implement simulator for ATSI sending/receiving.

vetss commented 8 years ago

Hello @vgsub,

thanks for you work.

1) I have committed your update. I have commited it only to netty-2 branch. We have not finished to add new code into master branch because we will release it soon. netty-2 branch will be renaming to master in some time. This branch contains an updated code with support of netty and congestion control. 2) I have fixed some code bugs and code style issues 3) I have created an issue for your case: https://github.com/RestComm/jss7/issues/108 Please check it. The code is not implemented fully. I have left in that issue tasks that are still pending.

Unfortunately I don't have real traces so I'm unable to create unit test for this operation. If you provide traces I implement tests.

We do not unfortunately have real traces for it. We create unit tests offten even without them by encoding / decoding of all possible parameters. Please check as we do it for other primitives. Also MAPFunctiolatTest is missed. We need it as just an sending requst / receiving response with a minimal possible set of paramters.

Also I didn't implement simulator for ATSI sending/receiving.

vetss commented 8 years ago

@vgsub,

I did not find https://github.com/RestComm/jss7/issues/4 when I was creating https://github.com/RestComm/jss7/issues/108.

Let's continue work at t he new issue (108)