Adding of MAP operation: anyTimeSubscriptionInterrogation

[vetss]

We need to implement anyTimeSubscriptionInterrogation MAP operation.

[vetss]

Base implementation is added by: https://github.com/RestComm/jss7/commit/eb97801100a95f91772a3684f39576ec545a9bee I also added a commit that fixes soem issues and code style https://github.com/RestComm/jss7/commit/773bbafecbc78a44e9d276bba632e53c74db8a60

[vetss]

We need to add some missed functionality / fix some bugs after adding of

• MAPParameterFactory:
  • remove createAnyTimeSubscriptionInterrogationRequest, createAnyTimeSubscriptionInterrogationResponse (we do not add top level primitives there)
  • add of new added parameters: CAMELSubscriptionInfo, CallBarringData, CallForwardingData, CallHoldData, CallWaitingData, ClipData, ClirData, EctData, ExtCwFeature, MSISDNBS, ODBInfo, RequestedSubscriptionInfo
• toString(): "ArrayList" parameters must display each element in the ArrayList. Whole ArrayList.toString brings no good data. So the code must look like. An example pf how to implement it is: org.mobicents.protocols.ss7.map.service.lsm.ReportingPLMNListImpl - parameter plmnList. Needed parameters to update:
  • CAMELSubscriptionInfoImpl: oBcsmCamelTDPCriteriaList, tBcsmCamelTdpCriteriaList, vtBcsmCamelTdpCriteriaList, mtSmsCamelTdpCriteriaList, oImBcsmCamelTdpCriteriaList, vtImBcsmCamelTdpCriteriaList
  • CallBarringDataImpl:callBarringFeatureList
  • CallForwardingData: forwardingFeatureList
  • CallWaitingData: cwFeatureList
  • MSISDNBS: basicServiceList
  • AnyTimeSubscriptionInterrogationResponse: msisdnBsList, csgSubscriptionDataList
• missed unit tests:
  • CAMELSubscriptionInfo, CallBarringData, CallForwardingData, CallHoldData, CallWaitingData, ClipData, ClirData, EctData, ExtCwFeature, MSISDNBS, ODBInfo, RequestedSubscriptionInfo
• missed MAPFunctionalTest

[vetss]

We need also update MAP RA for it: https://github.com/RestComm/jain-slee.ss7/issues/8

[vetss]

I have committed your update with little fixes into netty-2 branch from https://github.com/RestComm/jss7/pull/112. Thanks for your work.

This is a list what is still missed: 1) no unit test provides:

• AnyTimeSubscriptionInterrogationRequestImpl,
• AnyTimeSubscriptionInterrogationResponseImpl,
• ExtCwFeature

2) need the second unit test that will cover parameters that are missed (null) in the existing unit test (in the second unit test you can leave already tested field empty/null that are optional). This is important to me sure that no primitive encoding / decoding were tested and no errors

• CAMELSubscriptionInfo,
• CallBarringDataImpl,
• CallForwardingData,
• CallWaitingData,
• ClirDataTest,
• RequestedSubscriptionInfo,
• ODBInfo,
• MSISDNBS

[vetss]

Hello @vgsub

I have committed your update with some extra fixes. https://github.com/RestComm/jss7/commit/52a11b523f194490f61c952eaa8b908c5f93e343 https://github.com/RestComm/jss7/commit/03d9d3be53c5a40c94f520d71269e0b3cbfecc74

Thanks for your work.