search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
190 stars 221 forks source link

CAP FCI SMS xml serialization #127

Closed AlerantAppNGIN closed 7 years ago

AlerantAppNGIN commented 8 years ago

Hello,

I'd like to add XML serialization to the class that implement the FCI SMS function. I'll send a PR to this issue.

Best Regards, Gabor

vetss commented 8 years ago

Hello @AlerantAppNGIN

I have accepted your update into a single commit (into netty-2 branch): https://github.com/RestComm/jss7/commit/d52abc911a902c01c73f9be87f49ec761cddbce9

Thank for your work.

1) when you implement (de)serializing take into account that some paramentes may be null and yuo need to check it in code 2) may I ask you to make your PR as a change to netty-2 branch and make them as isolated commit / work (your PR contains now 5 commints) to simplify my work ? 3) we need to implement 2 unit tests for checking of XML serializing. Please finish this work.

vetss commented 8 years ago

Missed part is:

vetss commented 7 years ago

Hello @agafox

sorry for delayed response. I have committed your update and marked an operation as it has a support for XML serializing.

Final Fixing by: https://github.com/RestComm/jss7/commit/bd44f0b486292c9712f99131c900aa96cf9aa55c https://github.com/RestComm/jss7/commit/6d92e4b378848b9c524af804a9370efd719af561