search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
178 stars 218 forks source link

Fixes #127 #199

Closed agafox closed 7 years ago

agafox commented 7 years ago

Hello @vetss I've added xml serializing unit tests for FCIBCCCAMELsequence1SMSImpl and FurnishChargingInformationSMSRequestImpl. Also, I've changed classnames (for instance, FCIBCCCAMELsequence1Test -> FCIBCCCAMELsequence1SMSTest) in accordance with object it tests

vetss commented 7 years ago

Hello @agafox

I have added your commit, thanks for your work. Can we also get fixed of https://github.com/RestComm/jss7/issues/99 (also serializing issue) ?

agafox commented 7 years ago

Hello @vetss Thank you. I'll fix #99. Please assign it to me. Could you also take a look at #201. It's a kind of blocker in my project. And I prefer to fix it first.

vetss commented 7 years ago

Hello @agafox

I have sent you an invitation to become a contrubutor, please accept it. Only after it I can assign a ticket for you.