RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
178 stars 218 forks source link

ISUP: Update messages in accordance with ITU Q.763 #201

Closed agafox closed 7 years ago

agafox commented 7 years ago

In my project I found ISUP IAM messages with optional parameters from Q.763 (for instance, 'Called IN number', 'UID capability indicators', e.t.c) which don't defined in 'InitialAddressMessage' object.

So, any attempt to decode such messages leads to Exception.

I could try to review ISUP messages and update them in accordance with Q.763

vetss commented 7 years ago

Hello @agafox

thank you for opening an issue. Feel free to provide update for ISUP messages if you mean it is needed. We will include it into sources.

agafox commented 7 years ago

Hello @vetss

I've reviewed all ISUP messages. Only AIM is not up to date with ITU Q.763 25 optional parameters from Table 32 are absent in IAM jss7 implementation.

2 of this parameters not implemented in jss7 at all: 1) Number portability forward information 2) Calling geodetic location

I suggest to update IAM with 23 implemented in jss7 parameters and create new issue to implement parameters above because now I'm not sure I have enough time to do it (Calling geodetic location - very complex parameter...)

vetss commented 7 years ago

Hello @agafox

ok, let's start with what we have. Feel free to provide a PR to the staff you can cover.

vetss commented 7 years ago

Hello @agafox

I have added your update: https://github.com/RestComm/jss7/commit/9fd03cbeba93dee7419e9d65050dde2c43d59659

Will you be able to implement two missed parameters ? Should I keep the issue opened so far ?

agafox commented 7 years ago

Thanks @vetss

Let's close this issue, because I have no time to implement missed parameters in February and March.

I believe I'll come with pull request in future.

vetss commented 7 years ago

I am closing the issue now. Feel free to open a new one for finishing the work