RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
178 stars 218 forks source link

Fixes Issue #224 SCCP Routing based on calling party #230

Closed faizann closed 7 years ago

faizann commented 7 years ago

Fixes issu224 SCCP Routing based on callingGT Added code for using callingparty as secondary match when available in the routing. Also fixed bugs in modify/addrule in sccpexecutor and routerimpl. jss7-management-console work is in progress. CallingParty rule is used as secondary rule for sorting the rules when CalledRule is same for multiple rules. This allows better control on routing. CallingParty rule only matches SSN and GT TYPE and GT digits. It doesn't have mask as address overridden is done via new calling-party address id.

sccp rule create <id> <mask> <address-indicator> <point-code> <subsystem-number> <translation-type> <numbering-plan><nature-of-address-indicator> <digits> <ruleType> <primary-address-id> backup-addressid <backup-address-id> loadsharing-algo <loadsharing-algorithm> newcgparty-addressid <new-callingPartyAddress-id> origination-type <originationType> networkid <network-id> calling-ai <address-indicator> calling-pc <point-code> calling-ssn <calling-subsystem-number> calling-tt <calling-translation-type> calling-np <calling-numbering-plan> calling-nai <calling-nature-of-address-indicator> calling-digits <calling-digits> stackname <stack-name>

vetss commented 7 years ago

Hello @faizann

is your work completely done or you still need to finish some issues ? I am asking because you mentioned that "Tests are still failing". Please let me know.

faizann commented 7 years ago

Hi

The comment about test failing came from a squashed merge. The code is complete as to CLI + SCCP routing. The GUI is not done in this one as I wanted to be sure about the rest of the part before I handle the GUI.

vetss commented 7 years ago

Hello @faizann

I have added your commints, please check my comment in https://github.com/RestComm/jss7/issues/224