search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
178 stars 218 forks source link

Adding of CsvStatsPrinter #234

Closed vetss closed 7 years ago

vetss commented 7 years ago

We need to add another statistic output format - CSV.

vetss commented 7 years ago

Thanks for your PR: https://github.com/RestComm/jss7/pull/232

To accept the PR we need to add: 1) Configuring. We have now only GUI management (no CLI), but this GUI in several projects (JSS7, SMSC, USSD). Let's start with jss7-management-console. We need an option that will allow to select a type of statistic logging (verbose (old format) / CSV (new format) / or may be even both if this mode is needed). May be the simpliest is to make a general server level-option or also possible per a statistic campaign.

2) Adding comments into a manual: http://documentation.telestax.com/core/ss7/SS7_Stack_User_Guide.html#_managing_statistics

vetss commented 7 years ago

Fixed by: https://github.com/RestComm/jss7/commit/0098f895228b51db938de0605107f92acc5a1ed5 https://github.com/RestComm/jss7/commit/44ec4161b17523f92958cfa5b107e16de3650ad7 https://github.com/RestComm/jss7/commit/2e204957a90c63c308f4180b28cb0e6d226152ec https://github.com/RestComm/jss7/commit/2f0ccd61f9c12be6fa34763d97ae11a2000c0a1a

vetss commented 7 years ago

Hello

I have added your PR https://github.com/RestComm/jss7/pull/236 into master and non-netty branches. This work will be included into 7.3 release. Thanks for your work.

I added a little commit to have a class field as Enum that is more clear, you can check my commit RestComm/jss7@2f0ccd6