search

RestComm / jss7

RestComm Java SS7 Stack and Services
http://www.restcomm.com/
GNU Affero General Public License v3.0
186 stars 221 forks source link

Allow USSDString to be null #298

Closed okulikov closed 6 years ago

okulikov commented 6 years ago

At the moment when incoming message due to some reasons does not contain ussdString parameter MAP parser throws appropriate parsing exception. This exception then pop-up other exceptions till the underlying SCCP layer. This is not convenient because in sense of SCCP message is properly formatted and it contains sufficient information to handle it at MAP layer.

Instead of throwing parsing exception would be better to leave ussdString as null so application can do check on its own way and handle this accident gracefully using successfully decoded information.

knosach commented 6 years ago

hi @okulikov we can not leave ussdString as null because it breaks specification : if USSD Data Coding Scheme parameter is present, then the `USSD String' parameter has to be present. So I will reject your PR.

okulikov commented 6 years ago

@knosach The specification is completed and final. The goal is to communicate with legacy equipment where this is a real use case rather then investigating specs.