M3UA DUPU packets processing, misread parameters User and Cause

vasilileliuh commented 3 years ago

Is this a BUG REPORT or FEATURE REQUEST?:

kind bug

What happened:

During reading DUPU packets in UserCauseImpl class (org.restcomm.protocols.ss7.m3ua.impl.parameter) a first variable "user" receive value of field "Unavailability cause" (by RFC 4666, chapter 3.4.5, p. 43) and second variable "cause" receive value of field "User Identity". In result we have user = 1 and cause = 5 but it should be vice-versa and NullPointerExaption in org.mobicents.protocols.ss7.mtp.Mtp3UserPartBaseImpl$MsgSystemDeliveryHandler.run(Mtp3UserPartBaseImpl.java:347)

What you expected to happen:

Variable "user" should read data of field User Identity of DUPU packet and "cause" should read data of field Unavailability cause

How to reproduce it (as minimally and precisely as possible):

Looks like a human error from the initial 7 projects.

Anything else we need to know?:

Attached an example of DUPU packet (affected rows 76, 77) Dupu packet example.txt

Environment:

Restcomm JSS7 version (from startup logs): every version from 11/14/2015
Cloud provider or hardware configuration: n/a
OS (e.g. from /etc/os-release): n/a
Kernel (e.g. uname -a): n/a
Deployment method (e.g. application server version + config + method): n/a
Others:

yulianoifa-mobius commented 3 years ago

@rodin-andrey can you please provide the pcap/cap file for analysis BR Yulian Oifa

vasilileliuh commented 3 years ago

Hello, Yulian Oifa

Glad to hear your interest to that issue

Please see .pcap file attached

BR

Vasili Leliuh

вт, 25 мая 2021 г. в 12:36, yulianoifa-mobius @.***>:

@rodin-andrey https://github.com/rodin-andrey can you please provide the pcap/cap file for analysis BR Yulian Oifa

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RestComm/jss7/issues/329#issuecomment-847716464, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTC4G42GITOFJLXVXGZ233TPNVTDANCNFSM4XJB5TBA .

honphilemon commented 3 years ago

Please can anyone here share the link to me......can find it

RestComm / jss7

M3UA DUPU packets processing, misread parameters User and Cause #329