RestComm / load-balancer

RestComm Converged (SIP/HTTP/WebSockets/SMPP) Load Balancer
http://www.restcomm.com/
GNU Affero General Public License v3.0
26 stars 31 forks source link

Unnecessary WARN log on ACK for error response to initial request #128

Closed gyoetam closed 7 years ago

gyoetam commented 7 years ago

Scenario: incoming ACK on external port for error response to initial INVITE (401 in this case).

Issue: load balancer logs a WARN message:

2017-09-22 16:59:58,685 WARN pool-AffinityJAIN-thread-2 org.mobicents.tools.sip.balancer.SIPBalancerForwarder - A subsequent request should have two Route headers. Number of removed Route headers is 0. This indicates a client is removing important headers.

The log statement is not true for this request. The INVITE error response does not contain Record-Route headers, and ACKs to error responses are TU level requests sent on the same Route as the initial INVITE, irrespective of Record-Route anyway. As such, the incoming ACK correctly did not contain any Route headers.