search

RestComm / mediaserver-docker

Docker Image for RestComm Media Server at https://github.com/RestComm/mediaserver
http://www.restcomm.com/
GNU Affero General Public License v3.0
0 stars 6 forks source link

update configuration scripts to new format #3

Open hamsterksu opened 8 years ago

hamsterksu commented 8 years ago

new format - https://github.com/RestComm/Restcomm-Connect/issues/1020 https://github.com/RestComm/mediaserver/blob/issue70/bootstrap/src/main/config/mediaserver.xml

hamsterksu commented 8 years ago

@hrosa i think we should use/create some "smart" tool to edit xml files instead of sed this tool should provide ability to edit xml document by xpath sure we can create some python script and use it for this purpose.

it should be like xml value controller/address new_value xml attr resources/localConnection poolSize new_value xml attr endpoints/endpoint[@name="mobicents/bridge/"] poolSize new_value

WDYT?

hamsterksu commented 8 years ago

quick search - http://xmlstar.sourceforge.net/doc/UG/xmlstarlet-ug.html#idm47077139594320

hrosa commented 8 years ago

@hamsterksu this is something we've been discussing for some time, but unfortunately we never had the opportunity to actually do it.

Makes perfect sense to move to a proper xml editing tool, especially since the configuration files of RestComm platform grew quite complex.

hrosa commented 8 years ago

@hamsterksu are you available to lead this effort?

hrosa commented 8 years ago

@croufay can you please review work done by @hamsterksu on media server configuration script and sync with him? I know you're also doing some work related to this.

Here is the auto-config script used by ms-docker image.

deruelle commented 8 years ago

@croufay any news here ? @leftyb can you also have a look at that ?

croufay commented 8 years ago

@hamsterksu @deruelle

We have implemented the configuration using xpath. Here is an example

https://github.com/RestComm/Restcomm-Connect/blob/issue917/restcomm/configuration/config-scripts/as7-config-scripts/restcomm/autoconfig.d/config-dialogic-xms.sh

Regards

Charles

hamsterksu commented 8 years ago

@deruelle, @leftyb seems docker container doesn't contains the latest changes. last commit - 18 days ago docker image - 24 days ago https://hub.docker.com/r/restcomm/mediaserver-docker/tags/

thanks,

deruelle commented 8 years ago

@hamsterksu mmm strange, just triggered a new build