RestComm / restcomm-android-sdk

Android Mobile SDK to easily integrate communication features (WebRTC, messaging, presence, voice, video, screensharing) based on RestComm into native Mobile Applications
http://www.restcomm.com/
GNU Affero General Public License v3.0
154 stars 109 forks source link

Invalid RCDevice state and notifications #817

Closed atsakiridis closed 6 years ago

atsakiridis commented 6 years ago

Scenario:

Get in the App, all good, go to settings change push using invalid configuration (for example non existing account), go back to contacts activity (connectivity should show lost). Pull down notification drawer and disable wifi, push up and see status remaining not connected. Pull down notification drawer and enable wifi, push up and see status going back to connected, even though it shouldn't since push configuration is not good.

Some hints: The problem is that RCDevice.onConnectivityEvent() currently sets RCDevice state and calls onConnectivityUpdate() based ONLY on signaling status; it should also check status of last push registration or take into account if push was disabled.