RestComm / restcomm-android-sdk

Android Mobile SDK to easily integrate communication features (WebRTC, messaging, presence, voice, video, screensharing) based on RestComm into native Mobile Applications
http://www.restcomm.com/
GNU Affero General Public License v3.0
153 stars 109 forks source link

No exception if FCM server key is missing #837

Closed atsakiridis closed 6 years ago

atsakiridis commented 6 years ago

This seems like a regression in latest commits (possibly the one with changes in RCDevice.initialize() and new throw)? The result is that if you remove the App (to make sure prev settings are removed from preferences) and start with empty FCM server key setting in sign-in activity you will get no exception and remain disconnected with no error in the UI.

Another issue that it's tough to troubleshoot as there seem to be no logs for when a validation exception happens. Can we introduce an error type of log statement and print out the error code?