RestComm / sip-servlets

Leading SIP - IMS - WebRTC Application Server
http://www.restcomm.com/
GNU Affero General Public License v3.0
240 stars 181 forks source link

NPE when cancelling proxy branch #339

Open horacimacias opened 7 years ago

horacimacias commented 7 years ago

Using sip-servlets 4.0.125, ProxyBranchImpl's cancel method does

if(lastResponse.getStatus() > Response.OK && !recursedBranches.isEmpty()) {

problem is recursedBranches can be null so a NPE is thrown. Probably something like this would help:

if(lastResponse.getStatus() > Response.OK && recursedBranches != null && !recursedBranches.isEmpty()) {

Log Time

jaimecasero commented 6 years ago

thanks for reporting, ill check TCK testsuite with this change and merge appropiately