search

RestComm / smscgateway

RestComm SMS Gateway (SMSC) to send/receive SMS from/to Operators Network (GSM)
http://www.restcomm.com/
GNU Affero General Public License v3.0
127 stars 111 forks source link

MProcMessage - adding of MessageId parameter #200

Closed vetss closed 7 years ago

vetss commented 7 years ago

We need to add of MessageId parameter into MProcMessage mproc rules interface.

vetss commented 7 years ago

Fixed by: https://github.com/RestComm/smscgateway/commit/797c56f9878ca3f2a057ba7a7d47af922e033da0 https://github.com/RestComm/smscgateway/commit/cef89e82a0e22bce62dcac72191ea94203b5d6e9 https://github.com/RestComm/smscgateway/commit/c8fbd3284a5a1a3e20b65882091662d4bb275111

vetss commented 7 years ago

Hello @ovoo-unif , thanks for your update.

my comments : 1) we need to have MessageId as long because it is long in the current SMSC GW design 2) correlationIdValue.getCorrelationID() is not MessageId but some other parameter 3) we need to update a manual - update interfaces for mproc rules - http://documentation.telestax.com/core/smsc/SMSC_Gateway_Admin_Guide.html#_mproc_rules_fundamentals

I have fixed 1) and 2) Please add a fix for 3)

ovoo-unif commented 7 years ago

Ok,

I've asked Michal to take it after he's done with CSV Stats Printer.

Regards, adam

mniemiec commented 7 years ago

fix for 3): https://github.com/RestComm/smscgateway/pull/204

vetss commented 7 years ago

Hello @mniemiec

I have committed your uodate https://github.com/RestComm/smscgateway/pull/204 The issue is fixed.