search

RestComm / smscgateway

RestComm SMS Gateway (SMSC) to send/receive SMS from/to Operators Network (GSM)
http://www.restcomm.com/
GNU Affero General Public License v3.0
126 stars 112 forks source link

RsdsSbb stores serviceCenterAddress as instance variable of Sbb #272

Open faizann opened 6 years ago

faizann commented 6 years ago

It looks like RsdsSbb is using an instance variable to store value of serviceCenterSCCPAddress which is not really needed and also breaks the SLEE architecture. Luckily in this Sbb it is not harmful as the rest of code only uses returned values of sccpAddress. It is not a bug but it can become a bug if overlooked in later changes and someone decides to use the instance variable value.

https://github.com/RestComm/smscgateway/blob/master/core/slee/services/sbbs/src/main/java/org/mobicents/smsc/slee/services/mt/RsdsSbb.java#L94

gsaslis commented 6 years ago

Hi @faizann !

This sounds like a valid description. Would you care to open a PR with this? ;)

faizann commented 6 years ago

Sure. It is a small bit of code to do. I will send PR soon.

gsaslis commented 6 years ago

Awesome! Thanks - looking forward to it!