Fix for HTTP SBB NPE when checking initial HTTP event

RestComm / smscgateway

RestComm SMS Gateway (SMSC) to send/receive SMS from/to Operators Network (GSM)

http://www.restcomm.com/

GNU Affero General Public License v3.0

127 stars 111 forks source link

Fix for HTTP SBB NPE when checking initial HTTP event #276

Closed ovoo-unif closed 6 years ago

ovoo-unif commented 6 years ago

Hi,

due to possible issue in the HTTP servlet code, the HTTP TX service gets NPE (quite rarely, but still) when getting RequestURL from HttpServletRequest.

Here is the proposed change that should improve the service in such cases.

Please review, consider and merge in.

Thanks, regards, adam

gsaslis commented 6 years ago

Hey @ovoo-unif,

Plz also ping me on this one once CLA is signed, and plz rebase this if possible.

ovoo-unif commented 6 years ago

Hi Yorgos,

I've accepted the CLA and now have a question about re-basing. You want this commit to be put on top of the current master? If so I will create a new PR ok?

Regards, adam

gsaslis commented 6 years ago

Hi Adam,

Yes, sure please feel free to close this and open a new PR if that's easier for you. ;) 👍