search

RestComm / smscgateway

RestComm SMS Gateway (SMSC) to send/receive SMS from/to Operators Network (GSM)
http://www.restcomm.com/
GNU Affero General Public License v3.0
129 stars 112 forks source link

Fix for HTTP SBB NPE when checking initial HTTP event #280

Closed ovoo-unif closed 6 years ago

ovoo-unif commented 6 years ago

Hi,

it is depreciation of https://github.com/RestComm/smscgateway/pull/276

The content is the same, but done on the rebased branch. Now github shows 'able to merge'.

Comment from the original PR:

Hi,

due to possible issue in the HTTP servlet code, the HTTP TX service gets NPE (quite rarely, but still) when getting RequestURL from HttpServletRequest.

Here is the proposed change that should improve the service in such cases.

Please review, consider and merge in.

Thanks, regards, adam

Regards, adam

gsaslis commented 6 years ago

Thanks @ovoo-unif !

pushing this for review from the @RestComm/messaging-squad

vetss commented 6 years ago

Hello @ovoo-unif

Thanks for fixing of NPE bug. We will include your PR into a github and bitbucket branches.